make "virtual internal" to "virtual internal protected" to PreTransform and PostInverseTransform Axis baseclass

Oystein Bjorke 6 лет назад 0
This discussion was imported from CodePlex

chage wrote at 2014-03-26 19:27:

Hi Objo,
Good day. One question/request...
is there a reason not having PreTransform and PostInverseTransform declared as protected since it is marked as virtual for overriddes.

I have derived a custom axis class that requires PreTransform and PostInverseTransorm to be overridden (a norm std distribution z-index axis). I had it in OxyPlot assembly previously which is fine when they were internal only. I found that it creates alot of work when i merge with your code from time to time.

So decided to move the custom axis class out of the assembly, but hit into limitation of these method not being protected.

if possible, please mark those protected so it doesnt defeat the purpose of having the derived class overrides them.

thanks again for the cool library.

objo wrote at 2014-03-26 20:07:

I was hoping we could get rid of these methods, but I have not found a good way to do this yet. It seems to be convenient to use these methods in the CalculateActualMaximum, CalculateActualMinimum and UpdateTransform methods in the Axis class. So I agree with you, let use change to protected to allow overriding in custom axes!
ps: it is very cool to hear of such advanced use of the library!

chage wrote at 2014-03-26 21:05:

Thanks objo! Saw the code changes got checked in. that was fast!

Сервис поддержки клиентов работает на платформе UserEcho